-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop the initial resolve step for dynamic references #1142
Drop the initial resolve step for dynamic references #1142
Conversation
The
|
ad4e9b1
to
01a56ea
Compare
The value of the "$dynamicRef" property MUST be a string which is a | ||
IRI-Reference that contains a valid <xref target="anchor">plain name | ||
fragment</xref>. Resolved against the current IRI base, it indicates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need the first sentence, which describes the value form.
"$dynamicAnchor" and only exhibits runtime dynamic behavior when referenced | ||
with "$dynamicRef". | ||
(schemas that reference themselves). The extension point is defined | ||
with "$dynamicAnchor", and only exhibits runtime dynamic behavior when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comma isn't necessary in the current form. If you want to include a comma, the second half of the sentence needs to be a complete sentence.
with "$dynamicAnchor", and only exhibits runtime dynamic behavior when | |
with "$dynamicAnchor", and it only exhibits runtime dynamic behavior when |
with "$dynamicAnchor", and only exhibits runtime dynamic behavior when | ||
referenced with "$dynamicRef". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to remove the "$dynamicAnchor
produces a $ref
-able anchor" behavior, we need to adjust this sentence. We decided that dynamic behavior always occurs because referencing with $ref
is now impossible.
We'll likely need to make changes in the $dynamicAnchor
section as well.
@jdesrosiers do you want to pick this up again? |
Yes, this needs to get done before we can release, but I don't have the capacity to work on this at the moment. |
Closing in favor of ☝️ |
Fixes #1140
Without bookending or initial resolution, describing how dynamic references work becomes much more straightforward.
This is provided as a draft PR just to show what the change might look like if agreed upon. Any discussion about whether or not to make this change should happen in #1140.