Additional cleanup for dynamic references #1589
Merged
+92
−97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Clarification
Issue & Discussion References
Summary
This is mostly cleanup building on #1555, although I rewrote a couple of parts I though needed it.
The main objective is to achieve consistent and correct usage of terms around fragment identifiers. Here are the definitions I'm using.
#
character in an IRI.$anchor
creates a plain name fragment identifier.#
and is followed by a fragment identifier.fragment-- This term by itself is ambiguous and imprecise. I replaced all usages with a more precise term from the above terms.Here's a list of the other notable changes.
$dynamicAnchor
does not create a fragment identifier. It's a special kind of identifier unique to the dynamic reference mechanism. Specifically, you can't use the identifier created by$dynamicAnchor
in an IRI.$dynamicRef
Everything else is minor grammar fixes or whitespace cleanup.
Does this PR introduce a breaking change?
No. (Actually, the issue this closes is a breaking change, but this PR doesn't break anything. This is just cleanup related to and around that change.)