Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regression with singleton sequence of array type #531

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

andrew-coleman
Copy link
Member

Change the logic for promoting a singleton sequence of array type into an array of arrays. The logic was put in to fix issue #399 but caused an unintended regression as described in issue #462.

resolves #462

Signed-off-by: andrew-coleman [email protected]

@andrew-coleman andrew-coleman marked this pull request as draft August 16, 2021 16:37
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2ccb395 on array_sequences into 661e1d6 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2ccb395 on array_sequences into 661e1d6 on master.

@andrew-coleman andrew-coleman marked this pull request as ready for review August 18, 2021 08:04
@mattbaileyuk mattbaileyuk merged commit ccb0109 into master Aug 18, 2021
@mattbaileyuk mattbaileyuk deleted the array_sequences branch August 18, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Behavior of [] between version 1.7.0 and 1.8.3
3 participants