-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Libraries: add beatt87 jose-swift library JWT with all JWS algorithms and JWE key algorithms and encryption algorithms, nested JWTs #678
Conversation
Hi @byron-okta. Hope everything is ok. Ive seen that as well 2 other PRs to add libraries to You seem to be the one maintaining this repo, so I would kindly ask if it's possible to review this PR and the other 2 open, or point to whom should we ask to review?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
88ec083
to
4101b65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for your contribution @beatt83
Thank you @byron-okta happy to see this going through :) |
Hey @beatt83 , there is a new policy on the repository that requires all commits to be signed. Could you please sign the commit on this branch 🙏? Here is a document from GH about singing commits that can guide you |
Add a jose library that adds support of Jose (JWA, JWK, JWS, JWE, JWT). Supported JWT features: - Signing with all JWS algorithms including EDDSA and ES256K. - Encrypting with all JWE algorithms including ECDH-1PU. - Nested JWTs. - Validation of iss, sub, aud, exp, nbf, iat. - Support of jti, typ and cty.
4101b65
to
d1ab269
Compare
@byron-okta no worries totally understandable. Just signed ;) Thank you |
Add a jose library that adds support of Jose (JWK, JWS, JWE, JWT). https://github.com/beatt83/jose-swift
This library supports fully JWS and JWE, the JWT implementation is built on top of that foundation.
Supported JWT features: