Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libraries: add beatt87 jose-swift library JWT with all JWS algorithms and JWE key algorithms and encryption algorithms, nested JWTs #678

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

beatt83
Copy link
Contributor

@beatt83 beatt83 commented Jan 21, 2024

Add a jose library that adds support of Jose (JWK, JWS, JWE, JWT). https://github.com/beatt83/jose-swift

This library supports fully JWS and JWE, the JWT implementation is built on top of that foundation.

Supported JWT features:

  • Signing with all JWS algorithms including EDDSA and ES256K.
  • Encrypting with all JWE algorithms including ECDH-1PU.
  • Nested JWTs (Encrypted+Encrypted, Encrypted+Signed, Signed+Encrypted).
  • Validation of iss, sub, aud, exp, nbf, iat.
  • Support of jti, typ and cty.

@beatt83 beatt83 changed the title add beatt87 jose-swift library Libraries: add beatt87 jose-swift library Jan 21, 2024
@beatt83 beatt83 changed the title Libraries: add beatt87 jose-swift library Libraries: add beatt87 jose-swift library JWT with all JWS algorithms and JWE key algorithms and encryption algorithms, nested JWTs Jan 21, 2024
@beatt83
Copy link
Contributor Author

beatt83 commented Apr 20, 2024

Hi @byron-okta. Hope everything is ok.

Ive seen that as well 2 other PRs to add libraries to jwt.io website are waiting some for more than 6 months already.
(#668)
(#664)

You seem to be the one maintaining this repo, so I would kindly ask if it's possible to review this PR and the other 2 open, or point to whom should we ask to review?
All this PR's followed the instructions on how request to add libraries, and although I understand the it might take time, 6 months waiting without a reply is a lot.

jwt.io is an important resource to share and find JWT libraries for your platform/language.

Copy link
Contributor

@byron-okta byron-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @beatt83, thank you for contributing to this project. I apologize for taking us so long to review your pull request.

So far, it is looking good; I left a comment before approving it. Could you please take a look @beatt83 ?

@beatt83 beatt83 force-pushed the freatu/add-jose-swift-librarie branch from 88ec083 to 4101b65 Compare October 15, 2024 18:18
Copy link
Contributor

@byron-okta byron-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you for your contribution @beatt83

@beatt83
Copy link
Contributor Author

beatt83 commented Oct 15, 2024

Thank you @byron-okta happy to see this going through :)

@byron-okta
Copy link
Contributor

Hey @beatt83 , there is a new policy on the repository that requires all commits to be signed. Could you please sign the commit on this branch 🙏? Here is a document from GH about singing commits that can guide you

Add a jose library that adds support of Jose (JWA, JWK, JWS, JWE, JWT).

Supported JWT features:

- Signing with all JWS algorithms including EDDSA and ES256K.
- Encrypting with all JWE algorithms including ECDH-1PU.
- Nested JWTs.
- Validation of iss, sub, aud, exp, nbf, iat.
- Support of jti, typ and cty.
@beatt83 beatt83 force-pushed the freatu/add-jose-swift-librarie branch from 4101b65 to d1ab269 Compare October 15, 2024 21:14
@beatt83
Copy link
Contributor Author

beatt83 commented Oct 15, 2024

@byron-okta no worries totally understandable. Just signed ;) Thank you

@florkaa florkaa merged commit c4ecc6d into jsonwebtoken:master Oct 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants