Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add persistence to the ad banner with local storage #707

Closed
wants to merge 7 commits into from
Closed

Feat: Add persistence to the ad banner with local storage #707

wants to merge 7 commits into from

Conversation

byron-okta
Copy link
Contributor

@byron-okta byron-okta commented Oct 7, 2024 •
edited
Loading

Description

This PR does the following:

  • Add persistence of the state for the ad banner through local storage, so when users close the ad banner for the current campaign value defined by the messageBar.id.value property, it won't show the ad banner when users revisit the page.
  • Updates the copy for the ad banner to promote the best of devday.

How to test it

  • Navigate to the home page and verify that it loads the ad banner. Then, click on the close icon and refresh the page. Verify that it doesn't show the ad banner again.

DanOnCall
DanOnCall previously approved these changes Oct 10, 2024
View reviewed changes
@byron-okta
Copy link
Contributor Author

Closing in favor of #710

@byron-okta byron-okta closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanOnCall DanOnCall DanOnCall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byron-okta @DanOnCall