Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove column schema #477

Merged
merged 11 commits into from
Sep 20, 2023
Merged

Feature/remove column schema #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f41b31d
feat: remove using column_schema
sean-k1 Sep 15, 2023
fe1a582
remove testcase
sean-k1 Sep 15, 2023
18e4d11
remove set, enum
sean-k1 Sep 16, 2023
aa1ecdf
fix: testcase
sean-k1 Sep 16, 2023
6aa3872
table init changed
sean-k1 Sep 16, 2023
06ddd9f
remove ununsed variable
sean-k1 Sep 16, 2023
171b57d
check possible optional metadata version And delete get Table informa…
sean-k1 Sep 18, 2023
782184a
Column Values add
sean-k1 Sep 18, 2023
1196c06
change comment BINLOG_ROW_IMAGE
sean-k1 Sep 18, 2023
e7dff22
Merge branch 'main' into feature/remove-column-schema
sean-k1 Sep 19, 2023
bb7c711
retry github action
sean-k1 Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions pymysqlreplication/binlogstream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,12 +565,10 @@ def __check_optional_meta_data(self):
logging.log(
logging.WARN,
"""
Setting The Variable Value BINLOG_ROW_METADATA = FULL
Setting The Variable Value BINLOG_ROW_METADATA = FULL, BINLOG_ROW_IMAGE = FULL.
By Applying this, provide properly mapped column information on UPDATE,DELETE,INSERT.
""",
)
else:
self.__optional_meta_data = True

def fetchone(self):
while True:
Expand Down
1 change: 0 additions & 1 deletion pymysqlreplication/row_event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ def __init__(self, from_packet, event_size, table_map, ctl_connection, **kwargs)
self.nbd_info_length, self.nbd_info_format = struct.unpack(
"<BB", self.packet.read(2)
)

self.nbd_info = self.packet.read(self.nbd_info_length - 2)
# partition information
elif self.extra_data_type == 1:
Expand Down