Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive automated testing #628

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

etam
Copy link
Contributor

@etam etam commented Mar 10, 2025

Description

  • Revive automated testing. Both with github actions and with docker-compose-test.yml.
  • Run as much tests on MariaDB as possible (there are still some tests skipped for MariaDB with "TODO" messages)

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Other (please specify below)

Maintenance

Checklist

  • I have read and understood the CONTRIBUTING.md document.
  • I have checked there aren't any other open Pull Requests for the desired changes.
  • This PR resolves an issue #[Issue Number Here].

Tests

  • All tests have passed.
  • New tests have been added to cover the changes. (describe below if applicable).

Additional Information

  • mariadb client inside python:3.11-alpine docker image was failing to connect to servers with errors about self-signed certificates. So I just changed it to python:3.11.
  • I have no idea what mysql-5-ctl was for, so I just removed it.

@julien-duponchelle
Copy link
Owner

Thanks !!! Just the day I need it !

@julien-duponchelle julien-duponchelle merged commit 9cbb705 into julien-duponchelle:main Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants