Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build step #40

Merged
merged 2 commits into from
Jun 7, 2020
Merged

Add build step #40

merged 2 commits into from
Jun 7, 2020

Conversation

ericphanson
Copy link
Contributor

Fixes #39

ericphanson
ericphanson commented Jun 6, 2020
View reviewed changes
src/BARON.jl
@@ -1,11 +1,11 @@
__precompile__()
Copy link
Contributor Author

@ericphanson ericphanson Jun 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Precompilation is the default on Julia 0.7+ (JuliaLang/julia#26991), so adding the line here isn't needed anymore

joehuchette
joehuchette approved these changes Jun 7, 2020
View reviewed changes
Copy link
Contributor

@joehuchette joehuchette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! (I'll fix the typo in a separate commit).

src/BARON.jl
include(joinpath(@__DIR__, "..", "deps", "path.jl"))
catch
error("""BARON.jl was not built correctly.
Set the envionmental variable `BARON_EXEC` and run `using Pkg; Pkg.build("BARON")`.""")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*environment

Copy link
Contributor Author

@ericphanson ericphanson Jun 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch!

@joehuchette joehuchette merged commit dee4c6a into jump-dev:master Jun 7, 2020
@ericphanson ericphanson deleted the build-step branch June 7, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joehuchette joehuchette joehuchette approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If you forget the environmental variable at first using time, it's hard to fix
2 participants
@ericphanson @joehuchette