Fix index set parsing in JuMP macros on Julia 1.0. #1428
Conversation
This is a change introduced between Julia v0.7 and v1.0.
src/parseexpr.jl
Outdated
| @@ -4,7 +4,11 @@ | |||
| # file, You can obtain one at http://mozilla.org/MPL/2.0/. | |||
|
|
|||
| function tryParseIdxSet(arg::Expr) | |||
| if arg.head === :(=) | |||
| if arg.head === :kw # Julia 1.0 onwards. | |||
There was a problem hiding this comment.
It's better to use explicit VERSION checks so that they can be removed semi-automatically in the future.
There was a problem hiding this comment.
Should the version check be added for the old behaviour of the new behaviour?
There was a problem hiding this comment.
I don't think we have a convention, just as long as it's clear which code blocks can be removed when.
Codecov Report
@@ Coverage Diff @@
## master #1428 +/- ##
==========================================
- Coverage 88.93% 88.88% -0.05%
==========================================
Files 25 25
Lines 3677 3681 +4
==========================================
+ Hits 3270 3272 +2
- Misses 407 409 +2
Continue to review full report at Codecov.
|
|
For reference it was here: |
This is a change introduced between Julia v0.7 and v1.0.