only write browser files if we're launching the browser

[hhuuggoo]

closes #1087

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.

You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[codecov]

Codecov Report

Base: 80.05% // Head: 79.88% // Decreases project coverage by -0.17% ⚠️

Coverage data is based on head (1cdeefa) compared to base (a220430).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1133      +/-   ##
==========================================
- Coverage   80.05%   79.88%   -0.18%     
==========================================
  Files          68       68              
  Lines        8053     8053              
  Branches     1591     1591              
==========================================
- Hits         6447     6433      -14     
- Misses       1182     1198      +16     
+ Partials      424      422       -2     

Impacted Files	Coverage Δ
jupyter_server/serverapp.py	79.01% <0.00%> (-0.81%)	⬇️
...ter_server/services/kernels/connection/channels.py	58.49% <0.00%> (-1.11%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[blink1073]

Thank you!

[welcome]

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️

[bollwyvl]

Still investigating, but this may have broken jupyterlab browser check: https://github.com/jupyterlab/jupyterlab/blob/d780397fef0078cb32864e4b74494a46bbff89ee/jupyterlab/browser_check.py#L90

[hhuuggoo]

Still investigating, but this may have broken jupyterlab browser check: https://github.com/jupyterlab/jupyterlab/blob/d780397fef0078cb32864e4b74494a46bbff89ee/jupyterlab/browser_check.py#L90

Ah - really sorry about that. I don't quite understand the CI setup here? It looks like tests_check failed, but - what is that? (since it does not look like tests are run there?)