Skip to content

Update deprecation warning #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 22, 2022
Merged

Update deprecation warning #1148

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5784c3f
update deprecation warning
Carreau Dec 22, 2022
6f5f268
Update jupyter_server/utils.py
blink1073 Dec 22, 2022
1bdf131
Merge branch 'main' into depv
blink1073 Dec 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions jupyter_server/utils.py
View file
Original file line number Diff line number Diff line change
@@ -181,9 +181,11 @@ def _check_pid_posix(pid):


async def run_sync_in_loop(maybe_async):
"""**DEPRECATED**: Use ``ensure_async`` instead."""
"""**DEPRECATED**: Use ``ensure_async`` from jupyter_core instead."""
warnings.warn(
"run_sync_in_loop is deprecated, use 'ensure_async'", DeprecationWarning, stacklevel=2
"run_sync_in_loop is deprecated since Jupyter Serve 2.0, use 'ensure_async' from jupyter_core instead",
DeprecationWarning,
stacklevel=2,
)
return ensure_async(maybe_async)