Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for tornado6 #43

Merged
merged 2 commits into from
Mar 8, 2019
Merged

Fix for tornado6 #43

merged 2 commits into from
Mar 8, 2019

Conversation

maartenbreddels
Copy link
Contributor

maartenbreddels added a commit to maartenbreddels/voila that referenced this pull request Mar 7, 2019
@maartenbreddels
test using fix in jupyter-server/jupyter_server#43
9d9d384
@maartenbreddels maartenbreddels mentioned this pull request Mar 7, 2019
Merged
@maartenbreddels
Copy link
Contributor Author

Missed a part (not working locally), but the tests still pass :(

@SylvainCorlay
Copy link
Contributor

(not working locally)

Does this not work?

@maartenbreddels
Copy link
Contributor Author

Before that second backport, it was not working locally while the unittest passed on travis (meaning coverage is not ideal).

However, now it is fixed.

@SylvainCorlay SylvainCorlay merged commit ef3820b into jupyter-server:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does not work with tornado 6
3 participants
@maartenbreddels @SylvainCorlay @willingc