-
Notifications
You must be signed in to change notification settings - Fork 3k
Start using spark4-preview versions #2159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
ebae745
a702f5e
c5b22ef
f4db591
ded1dee
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,7 +63,7 @@ USER ${NB_UID} | |
RUN mamba install --yes \ | ||
'grpcio-status' \ | ||
'grpcio' \ | ||
'pandas=2.0.3' \ | ||
'pandas=2.2.2' \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Went with |
||
'pyarrow' && \ | ||
mamba clean --all -f -y && \ | ||
fix-permissions "${CONDA_DIR}" && \ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,7 +36,7 @@ def get_latest_spark_version() -> str: | |
stable_versions = [ | ||
ref.removeprefix("spark-").removesuffix("/") | ||
for ref in all_refs | ||
if ref.startswith("spark-") and "incubating" not in ref and "preview" not in ref | ||
if ref.startswith("spark-") and "incubating" not in ref | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the only line we will have to revert to start using stable versions again (that's why I made a separate commit improving spark setup scripts) |
||
] | ||
|
||
# Compare versions semantically | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,12 +3,20 @@ | |
import logging | ||
|
||
from tests.conftest import TrackedContainer | ||
from tests.run_command import run_command | ||
|
||
LOGGER = logging.getLogger(__name__) | ||
|
||
|
||
def test_spark_shell(container: TrackedContainer) -> None: | ||
"""Checking if Spark (spark-shell) is running properly""" | ||
logs = run_command(container, 'spark-shell <<< "1+1"', timeout=60) | ||
logs = container.run_and_wait( | ||
timeout=60, | ||
no_warnings=False, | ||
tty=True, | ||
command=["bash", "-c", 'spark-shell <<< "1+1"'], | ||
) | ||
warnings = TrackedContainer.get_warnings(logs) | ||
assert len(warnings) == 1 | ||
assert "Using incubator modules: jdk.incubator.vector" in warnings[0] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess this might disappear when we switch to JDK 21, but that's a separate story and won't be a part of the switch to Python 3.12 |
||
|
||
assert "res0: Int = 2" in logs, "spark-shell does not work" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will describe the release schedule in this PR: #2072