Remove information about Docker Hub images from READMEs #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathbunnyru
commented
Feb 13, 2025
| @@ -1,11 +1,5 @@ | |||
| # Jupyter Notebook Python, R, Spark Stack | |||
|
|
|||
| > **Images hosted on Docker Hub are no longer updated. Please, use [quay.io image](https://quay.io/repository/jupyter/all-spark-notebook)** | |||
There was a problem hiding this comment.
After I merge this PR:
- Quay.io descriptions will update automatically
- Docker Hub descriptions will stay the same (so there will be information, that the images are outdated)
mathbunnyru
commented
Feb 13, 2025
| @@ -1,4 +1,4 @@ | |||
| # Jupyter Notebook Deep Learning Stack | |||
| # Jupyter Notebook PyTorch Deep Learning Stack | |||
There was a problem hiding this comment.
We have the same naming for PyTorch and TensorFlow images, I decided to change them slightly.
mathbunnyru
commented
Feb 13, 2025
Comment on lines
-5
to
-7
| [](https://hub.docker.com/r/jupyter/all-spark-notebook/) | ||
| [](https://hub.docker.com/r/jupyter/all-spark-notebook/) | ||
| [](https://hub.docker.com/r/jupyter/all-spark-notebook/ "jupyter/all-spark-notebook image size") |
There was a problem hiding this comment.
Unfortunately, this information is not available for Quay images, and I would rather not give any information, than give a wrong one
|
@consideRatio please take a look |
|
@consideRatio friendly ping |
consideRatio
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket if applicable
Checklist (especially for first-time contributors)