Skip to content

Enable building contributed recipes in PRs #2213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mathbunnyru
Copy link
Member

Describe your changes

Issue ticket if applicable

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@mathbunnyru
Copy link
Member Author

With this change contributed recipes stage will run in parallel to pushing tags and merging tags, so we should decrease time it takes to build everything and then the contributed recipes.

@mathbunnyru
Copy link
Member Author

mathbunnyru commented Feb 17, 2025

In this PR I change both contributed-recipes and docker workflows.

This means that contributed-recipes runs twice :

  1. It is triggered because PR changes the workflow file. It runs using images already pushed to the registry: https://github.com/jupyter/docker-stacks/actions/runs/13377348557/job/37359262602?pr=2213
  2. As part of docker.yml workflow. This doesn't use registry at all and uses images built during running docker.yml: https://github.com/jupyter/docker-stacks/actions/runs/13377348556/job/37359703793?pr=2213

@mathbunnyru mathbunnyru merged commit 3fc8373 into jupyter:main Feb 17, 2025
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant