Skip to content

First upload artifacts and then run tests to make sure we can easily … #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

mathbunnyru
Copy link
Member

…debug broken images

Describe your changes

Issue ticket if applicable

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@mathbunnyru
Copy link
Member Author

Now, we're first running tests and if they fail, we don't have any debug information about the image.
I want to first upload manifests and so on (small files), then upload image (it's relatively reliable), and then run tests (this sometimes break).

@@ -458,11 +458,7 @@ jobs:
{ image: all-spark-notebook, variant: default },
]
needs: [aarch64-images-tag-push, x86_64-images-tag-push]
if: |
Copy link
Member Author

@mathbunnyru mathbunnyru Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed in this repo: #2091 (comment)

And it actually makes some harm:
https://github.com/jupyter/docker-stacks/actions/runs/13362035735

In this run, testing aarch64 r-notebook failed.
In my opinion, we should have not even tried to merge tags.
Instead, we tried, but only failed because manifest file was not available (because we were uploading it after running tests).

Instead, we should keep this condition simple and in accordance with other places.

@mathbunnyru
Copy link
Member Author

Having artefacts is extremely useful when for example x86_64 tests are fine, but there is a problem with aarch64 image (it builds as well, but tests don't work).
This is the case we have right now.

@mathbunnyru
Copy link
Member Author

Seems to work, I'm able to download r-notebook aarch64 artefacts, even though the job fails.
This should help to debug the problems with the images due to incompatible packages.

@mathbunnyru
Copy link
Member Author

Difference between newly built R image and the last successful is the following:

<   r-cli                          3.6.3
---
>   r-cli                          3.6.4
36c36
<   r-dials                        1.3.0
---
>   r-dials                        1.4.0
121c121
<   r-parsnip                      1.2.1
---
>   r-parsnip                      1.3.0
145c145
<   r-r6                           2.5.1
---
>   r-r6                           2.6.1
156c156
<   r-recipes                      1.1.0
---
>   r-recipes                      1.1.1
189c189
<   r-testthat                     3.2.1.1
---
>   r-testthat                     3.2.3

@mathbunnyru mathbunnyru merged commit 3ca2674 into jupyter:main Feb 17, 2025
48 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant