Refactor healthcheck tests to use one function #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathbunnyru
commented
Mar 20, 2025
|
|
||
| status = get_health(running_container) | ||
| if status == "healthy": | ||
| return status |
There was a problem hiding this comment.
Fast exit in case get_health reports the status is healthy
mathbunnyru
commented
Mar 20, 2025
| ) | ||
|
|
||
| # giving some time to let the server start | ||
| finish_time = time.time() + 5 |
There was a problem hiding this comment.
5 is actually a bug here, because this way it tests nothing - if I put 5 in tests above they give an error, as it's not enough time for our containers
mathbunnyru
commented
Mar 20, 2025
|
|
||
| # giving some time to let the server start | ||
| finish_time = time.time() + 10 | ||
| sleep_time = 1 |
There was a problem hiding this comment.
Sleeping 1 second instead of 0.1, because otherwise we produce too much logs when running pytest directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket if applicable
Checklist (especially for first-time contributors)