Test server listening on IPv4/IPv6

[mathbunnyru]

Describe your changes

Issue ticket if applicable

Checklist (especially for first-time contributors)

• I have performed a self-review of my code
• If it is a core feature, I have added thorough tests
• I will try not to use force-push to make the review process easier for reviewers
• I have updated the documentation for significant changes

[mathbunnyru]

All the credit goes to @manics and #2206

Just wanted to test a few different things here.

[mathbunnyru]

The error we get is could not find an available, non-overlapping IPv6 address pool among the defaults to assign to the network

It was reported here: moby/moby#41438
Which was marked as duplicate of: moby/moby#42801
Which was fixed in: moby/moby#47768
And released in: https://github.com/moby/moby/releases/tag/v27.0.1, on Jun 25, 2024

Ubuntu 24.04 runner uses Docker Client 26: https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md
And Docker Engine Version 26.* will be updated to Docker Engine Version 28* from 2025-05-09: actions/runner-images#11766

That's why I was not able to reproduce it locally, and self-hosted runners were working properly (they were using docker from docker repo, not ubuntu, so, more or less recent version has been installed).

My guess is that if I install latest docker inside our runners, it will work just fine.

[mathbunnyru]

There is a bug here - we fall through no matter if requests was successful or not, will fix it

[mathbunnyru]

When running from python still uses old version 'Name': 'Engine', 'Version': '26.1.3'

[manics]

Thanks for following this up, been busy with too many other things!

[mathbunnyru]

[gw1] [ 98%] PASSED tests/by_image/base-notebook/test_ips.py::test_ipv46

Yep, made it work, now it's time to make it work for other tests as well 😃

[mathbunnyru]

This is funny coincidence.
I refactored code around health check earlier today 😃

Didn't notice this bug.
We're using separate API client here, not the one from the docker_client fixture.

That's why it was impossible to make both healthcheck and ipv6 tests work.
Passing client as param and using it should fix the problem

[mathbunnyru]

This magic option changes anything - using it there is need to change other code around docker client creation, it will automatically use the latest docker client.

It is also more general, as it will also work for other places where we're creating docker client - in tagging, for example.

[mathbunnyru]

x86_64-base works 🎉

[consideRatio]

Wieeee nice debugging effort into this @mathbunnyru!!!!

[mathbunnyru]

@manics @consideRatio may I ask you to review this change?

Fun fact - I didn't even read what code by @manics about ipv6 does while doing all this 😆

@manics please, also tell me if you're ok if I just squash merge this PR as is (so the commit will be under my name).
If not, please, let me know what I should do - in any case, I don't want to take someone else's work and tell that it's mine.

[mathbunnyru]

Wieeee nice debugging effort into this @mathbunnyru!!!!

Thanks!
As you can see, it was quite a journey 😃

It's nice that when GitHub runners update their Docker version, we can just remove setup action, and everything else will stay the same (no changes to code at all).

[manics]

tell me if you're ok if I just squash merge this PR as is (so the commit will be under my name).

Fine with me!

[consideRatio]

This seems right! Thank you @manics and @mathbunnyru!!

[mathbunnyru]

Thanks!

All the images build and test just fine.
Rewrote check_listening.py a little bit to use one function for both ipv4 and ipv6, will merge this soon.