Improve logs around running docker #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathbunnyru
commented
Mar 23, 2025
| @@ -22,11 +22,10 @@ def __init__( | |||
| self.docker_client: docker.DockerClient = docker_client | |||
|
|
|||
| def __enter__(self) -> Container: | |||
| LOGGER.info(f"Creating container for image {self.image_name} ...") | |||
| LOGGER.info(f"Creating a container for the image: {self.image_name} ...") | |||
| default_kwargs = {"detach": True, "tty": True} | |||
There was a problem hiding this comment.
This class is more-or-less like TrackedContainer, so let's have same options here
mathbunnyru
commented
Mar 23, 2025
| @@ -48,6 +47,6 @@ def exec_cmd(container: Container, cmd: str) -> str: | |||
| exec_result = container.exec_run(cmd) | |||
| output = exec_result.output.decode().rstrip() | |||
| assert isinstance(output, str) | |||
| LOGGER.info(f"Command output: {output}") | |||
| LOGGER.debug(f"Command output: {output}") | |||
There was a problem hiding this comment.
Sometimes the output is huge, and in most cases it is not useful
mathbunnyru
commented
Mar 23, 2025
| @@ -1,7 +1,7 @@ | |||
| [pytest] | |||
| addopts = -ra --color=yes | |||
| log_cli = 1 | |||
| log_cli_level = DEBUG | |||
| log_cli_level = INFO | |||
There was a problem hiding this comment.
One can always use DEBUG if needed
mathbunnyru
commented
Mar 23, 2025
| @@ -41,8 +41,6 @@ class CondaPackageHelper: | |||
|
|
|||
| def __init__(self, container: TrackedContainer): | |||
| self.container = container | |||
|
|
|||
| LOGGER.info(f"Starting container {self.container.image_name} ...") | |||
There was a problem hiding this comment.
self.container.run_detached is going to log the same thing
mathbunnyru
commented
Mar 23, 2025
| @@ -101,7 +99,7 @@ def available_packages(self) -> dict[str, set[str]]: | |||
| ) | |||
| # Keeping command line output since `mamba search --outdated --json` is way too long ... | |||
| self.available = CondaPackageHelper._extract_available( | |||
| self.container.exec_cmd("mamba search --outdated --quiet") | |||
| self.container.exec_cmd("conda search --outdated --quiet") | |||
There was a problem hiding this comment.
mamba search --outdated --quiet doesn't work at all :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket if applicable
Checklist (especially for first-time contributors)