Skip to content

Make docker tag-push depend on contributed recipes in CI #2282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

mathbunnyru
Copy link
Member

Describe your changes

Issue ticket if applicable

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@mathbunnyru
Copy link
Member Author

We have a build where all the images were built and tested and therefore pushed to the registry: https://github.com/jupyter/docker-stacks/actions/runs/14375821119
But quite a simple recipe fails.

We should not push our images if recipes like this fail, so recipes can be viewed as tests for our images.

@mathbunnyru mathbunnyru merged commit 57bedab into jupyter:main Apr 11, 2025
42 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant