Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility update to notebook.html missing alt text #3226

Closed
snidersd opened this issue Jan 17, 2018 · 8 comments · Fixed by #3228
Closed

Accessibility update to notebook.html missing alt text #3226

snidersd opened this issue Jan 17, 2018 · 8 comments · Fixed by #3228
Labels
good first issue help wanted status:resolved-locked tag:Accessibility
Milestone
5.4

Comments

@snidersd
Copy link

snidersd commented Jan 17, 2018 •
edited by takluyver
Loading

Also see: jupyter/notebook#1801
After running the Dynamic Assessment Plugin for Chrome and the Digital Content Checker on notebook.html the following issue was found and can be corrected as indicated:
Line 48 requires alt text - <img class="current_kernel_logo" alt="Current Kernel Logo" src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7"/>
If the image is not important then include alt="".
@ns23
Copy link
Contributor

ns23 commented Jan 17, 2018

Can I work on this issue?

@takluyver
Copy link
Member

Go for it! Can you see what to do?

@ns23
Copy link
Contributor

ns23 commented Jan 17, 2018

I have to add alt="Current Kernel Logo" on the line below.

notebook/notebook/templates/notebook.html

Line 49 in 6526a19

<img class="current_kernel_logo" src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7"/>

Please correct me If I am wrong.

@takluyver
Copy link
Member

Sounds right, thanks!

@ns23
Copy link
Contributor

ns23 commented Jan 17, 2018

🙂 okay I will start working on it and create PR asap

ns23 added a commit to ns23/notebook that referenced this issue Jan 17, 2018
@ns23
Accessibility update to notebook.html missing alt text jupyter#3226
5e6231a
@ns23 ns23 mentioned this issue Jan 17, 2018
Merged
@ns23
Copy link
Contributor

ns23 commented Jan 20, 2018

@takluyver I have created the PR.Please review it.

@takluyver
Copy link
Member

Thanks @ns23

@ns23
Copy link
Contributor

ns23 commented Jan 24, 2018

Welcome. I am looking forward to contribute more to this project ☺️

@takluyver takluyver mentioned this issue Mar 10, 2018
Closed
@minrk minrk added this to the 5.4 milestone Jun 15, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue help wanted status:resolved-locked tag:Accessibility
Projects
None yet
Milestone
5.4
Development

Successfully merging a pull request may close this issue.

[WIP] Updated image alt text in notebook.html ns23/notebook
5 participants
@minrk @takluyver @Carreau @ns23 @snidersd