Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A single recursive link in a directory will make it unviewable #4669

Closed
scanon opened this issue Jun 12, 2019 · 1 comment
Closed

A single recursive link in a directory will make it unviewable #4669

scanon opened this issue Jun 12, 2019 · 1 comment

Comments

@scanon
Copy link
Contributor

scanon commented Jun 12, 2019

If a directory contains a recursive symlink, then the file manager will return a 500 if you try to list it. It should probably just skip the bad link.

Test
ln -s self self
and open in the file manager.

I'll put posting a PR for a fix.

scanon added a commit to scanon/notebook that referenced this issue Jun 12, 2019
… the

recusrive symlink error and moves on.  It is possibble that the
try/except belongs in the utils but I wanted to limit the scope.
blink1073 pushed a commit that referenced this issue Jun 7, 2020
* This is a potential fix to issue #4669.  The fix simply catches the
recusrive symlink error and moves on.  It is possibble that the
try/except belongs in the utils but I wanted to limit the scope.

* It looks like too many levels is error number 40 on linux.

* Switch to using errno instead of hardcoding the number.

* Fix spelling, smarter assert methods

* Log unrecognised errors and continue listing directory

* Skip recursive symlink test entirely on Windows

* Fix which test is skipped on Windows

Co-authored-by: Thomas Kluyver <[email protected]>
@kevin-bates
Copy link
Member

Fixed by #4670

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants