Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the loading of extensions in index.js #6399

Closed
jtpio opened this issue Sep 17, 2021 · 0 comments · Fixed by #6750
Closed

Improve the loading of extensions in index.js #6399

jtpio opened this issue Sep 17, 2021 · 0 comments · Fixed by #6750
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Sep 17, 2021

Problem

For now the packages are required in the main index.js file:

https://github.com/jupyterlab/retrolab/blob/4221275e895bb5f6be57c6ed85d7b1058eb9dde0/app/index.js#L83-L143

This is a bit tedious as this file needs to be updated when we add new dependencies to the package.json.

Proposed Solution

Maybe we don't want to have a different set of extensions loaded on the page depending on whether we are using the notebook, console, file browser or terminal? And instead have a single list defined in the package.json.

This would make it easier to streamline that part of the code, and hopefully make some of the boilerplate for loading federated extensions more reusable.

Additional context

This might also help with: jupyterlite/jupyterlite#118 (comment)

@jtpio jtpio added this to the 7.0 milestone Apr 27, 2022
@jtpio jtpio transferred this issue from jupyterlab/retrolab Apr 27, 2022
@jtpio jtpio mentioned this issue Feb 27, 2023
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant