-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate the lab and retro assets #118
Comments
Thanks for starting this. Some additional wrinkles on this:
|
add chunkHashname with contenthash in webpack
So i got a bit hung up on how we would refactor the various scripts to not make use of As we think about #104, I guess there's a latent refactor in the baseline of
|
Thinking about this more: what if we just made everything into federated extensions? Pro:
Con:
|
That sounds very tempting 👍 Probably up until now there was some assumptions on what the base apps like JupyterLab would offer. But in the end they too are also just a set of extensions and probably should not have better treatment than the others. |
Also somehow related: it would be nice if we could improve the way the apps are built so we don't duplicate efforts. For example when we make a change to RetroLab we wouldn't need to update lite too if the change is compatible (for instance when adding a new plugin). Example PRs for reference: #287 and jupyterlab/retrolab#187 Ideally, we would mostly work at the plugin level, with |
With #274, we are now using pyodide 0.18, which also ships an officially-maintaiend npm package. Semi-luckily, this ~100kb package is not a full distribution of all the WASM packages, which still needs to be handled out-of-band and match the package exactly, but does provide full typescript typings... and further includes typings from However, as this package is not exactly small, it will exacerbate our on-going OoM/too-many-files issues, but is probably pretty important to move forward. Since we'll have better metadata about what version of pyodide we're using, it's would probably be time to take the first step towards #45... i'm imagining we'll start a |
Problem
Tracking the following comment from https://github.com/jtpio/jupyterlite/issues/16#issuecomment-821980005 in its own issue:
Proposed Solution
/static
folderindex.js
,style.js
andbundle.js
toindex-lab.js
,index-retro.js
... so they don't collide./build
,bundle.js
and othersAdditional context
The text was updated successfully, but these errors were encountered: