Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error in i18n/README.md #3367

Merged
merged 2 commits into from
Mar 1, 2018
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion notebook/i18n/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ However…
run in).

Hint: if running Windows, you can set it in PowerShell with `${Env:LANG} = "xx_XX"`.
if running Ubuntu, you should set environment variable `LANGUAGE="xx_XX"`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least on my system, there's a variable called LANG rather than LANGUAGE. I think both are used, but I'm not sure which one has priority.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on my system(ubuntu14.04),LANG don't work

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forbxy If you are ssh'ing into Ubuntu 14.04, you will need to make sure that the following are set:

export LANG="en_US.utf8"
export LANGUAGE="en_US.utf8"
export LC_ALL="en_US.utf8"


2. The preferred language for web pages in your browser settings (`xx`) is
also used. At the moment, it has to be first in the list.
Expand All @@ -23,7 +24,7 @@ Hint: if running Windows, you can set it in PowerShell with `${Env:LANG} = "xx_X

### Requirements

- *pybabel* (could be installed `pip install pybabel`)
- *pybabel* (could be installed `pip install babel`)
- *po2json* (could be installed with `npm install -g po2json`)

**All i18n-related commands are done from the related directory :**
Expand Down