Add spelling and docstring enforcement #6669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
blink1073
force-pushed
the
more-ci-boost
branch
from
8f87e53 to
cb7c615
Compare
jtpio
reviewed
Dec 23, 2022
| @@ -69,6 +69,9 @@ jobs: | |||
| - uses: actions/checkout@v3 | |||
| - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 | |||
| - run: | | |||
| sudo apt-get update | |||
| sudo apt install enchant-2 # for spelling | |||
There was a problem hiding this comment.
Does it mean we would need to install that package locally if we want to build the docs manually?
There was a problem hiding this comment.
Ah ok just saw the try except block below, so it's probably fine and does prevent building the docs if the package is missing.
There was a problem hiding this comment.
Yes, on Windows it works automatically but on other systems you have to separately install enchant, so we add this block to avoid requiring the c library on posix.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.