Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Playwright snapshot update workflow #6724

Merged
merged 11 commits into from
Feb 9, 2023
+7 −1
Merged

Fix Playwright snapshot update workflow #6724

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
25da553
tmp: test updating UI
jtpio Feb 9, 2023
a512aea
Update `test_folder`
jtpio Feb 9, 2023
b9d773b
try debug with workflow dispatch
jtpio Feb 9, 2023
9809e60
try on push
jtpio Feb 9, 2023
d526342
fix
jtpio Feb 9, 2023
0a2fd50
try more triggers
jtpio Feb 9, 2023
fcd45df
debug
jtpio Feb 9, 2023
cd49901
Install pre-commit
jtpio Feb 9, 2023
9fbc658
run base setup
jtpio Feb 9, 2023
2460e8c
try disable git hooks
jtpio Feb 9, 2023
6440f2e
undo test changes
jtpio Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/playwright-update.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ jobs:
- name: Checkout
uses: actions/checkout@v3

- name: Base Setup
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1

- name: Checkout the branch from the PR that triggered the job
run: |
# PR branch remote must be checked out using https URL
Expand All @@ -42,6 +45,9 @@ jobs:
cd dist
python -m pip install -vv notebook*.whl

# disable git hooks
git config core.hooksPath no-hooks

- name: Install the test dependencies
run: |
cd ui-tests
Expand All @@ -52,6 +58,6 @@ jobs:
uses: jupyterlab/maintainer-tools/.github/actions/update-snapshots@v1
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
test_folder: playwright-tests
test_folder: ui-tests
start_server_script: 'null'
update_script: test:update --browser ${{ matrix.browser }}