-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JLab remix #120
JLab remix #120
Conversation
@jtpio I'm opening this early to get some feedback from you on the approach. I'm struggling to make a custom MainMenu in https://github.com/QuantStack/jupytercad/pull/120/files#diff-1f52c6c256b9d1ac999449f7408fa02a5d78de5489933d5c1a87326840225445 |
Thanks @martinRenou I'll have a look. It's possible there could an issue / breaking change in lab 4. That reminds me of an issue related to Menus when updating Notebook to a lab pre-release: jupyter/notebook#6757 (comment). Although it does not look the same issue exactly. |
Closing as replaced by Trung's PR |
This builds upon #119
It's still very much in progress