Fix Vulnerabilities #216
Merged
Fix Vulnerabilities #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The packages winston and loadsh was getting listed as vulnerables. After the command "npm audit fix", the project is using not vulnerable packages. And the "npm test" command is running without any failures
|
Thanks! LGTM! |
|
Last question, do you have any idea when you intend to release a new Docker Image with this fix? It would be able if we could use the image provided by you with this fix in our environment. |
|
@rafael-ladislau you can expect 4.2.0 today |
|
4.2.0 is out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The packages "winston" and "loadsh" was getting listed as vulnerable.
After the command "npm audit fix", the project is using not vulnerable
packages.
And the "npm test" command is running without any failures.
We are running JupyterHub in a FedRamp compliant environment, and We've checked the vulnerability after our regular security scans.
It would be great if we could use the Docker image you provide with this fix.