Improvements when things go wrong #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this logs a shorter message with just the error code instead of the traceback
new in 12.9, but falsy undefined should be harmless for old nodes, they just won't get the improved behavior
|
This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there: https://discourse.jupyter.org/t/improved-chp-health-endpoint/9315/2 |
|
This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there: https://discourse.jupyter.org/t/improved-chp-health-endpoint/9315/4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating improvements that could be related to the increase in CHP load on mybinder.org which is currently seeing an increase in routes to stopped endpoints. These are currently giving mostly EHOSTUNREACH, and unhandled
ERR_STREAM_WRITE_AFTER_ENDtracebacks, specifically in this request to the upstream error-target provider (jupyterhub).This is new in node 12.9, but the falsy behavior when this is undefined for old nodes should be fine, as it will just behave the same as it does now.