Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for 4.4.0 #316

Merged
merged 1 commit into from
May 26, 2021
Merged

Conversation

consideRatio
Copy link
Member

No description provided.

@consideRatio consideRatio requested a review from minrk May 26, 2021 12:58
@minrk minrk merged commit 7811728 into jupyterhub:main May 26, 2021
@manics
Copy link
Member

manics commented May 26, 2021

Should this be a breaking change since it removes statsd support?

@consideRatio
Copy link
Member Author

Woops, hmmm, yes i guess. I have never heard of anyone using statsd but you are right.

I have published it as 4.4.0 now though, do we take an action or just go with it?

@manics
Copy link
Member

manics commented May 26, 2021

I don't know....

@mriedem
Copy link
Contributor

mriedem commented May 26, 2021

Might have been good to mention that statsd metrics support was dropped in the same change. I didn't see a deprecation period for that or anything in the release notes.

Oops, saw this and commented in the commit, didn't notice this was already mentioned in the PR.

@mriedem
Copy link
Contributor

mriedem commented May 26, 2021

I have published it as 4.4.0 now though, do we take an action or just go with it?

IMO at least having a minor version bump for the dropped support is minimum good. It would have been nice for anyone using those options to have a deprecation period before those options are dropped outright (we're not using them but might have, it was something I was going to investigate for monitoring the chp in our k8s cluster).

At least a reasonable follow up would be to amend the changelog to mention the dropped statsd support so people that are using it don't have to dig too far down into git / PR history to find what broke them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants