Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require node 12+ explicitly #323

Merged
merged 2 commits into from
Jun 7, 2021
Merged

Require node 12+ explicitly #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9133a53
breaking: require node 12
consideRatio Jun 4, 2021
576d939
ci: stop testing against node 10
consideRatio Jun 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,9 @@ jobs:
strategy:
fail-fast: false # Do not cancel all jobs if one fails
matrix:
# IMPORTANT: Make sure to update package.json's enginges.node field to
# always require at least the oldest version.
node_version:
- "10"
- "12"
- "14"
- "15"
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"ws": "^7.0.0"
},
"engines": {
"node": ">= 6.0"
"node": ">= 12.0"
},
"engineStrict": true,
"main": "index.js",
Expand Down