Handle store backend errors #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtaniwaki
force-pushed
the
handle-backend-error
branch
from
097b1c4 to
c6f7cea
Compare
|
@minrk I find it very hard to review in CHP =/ Can you help out on this? |
Merged
to ensure it returns a promise, no matter where errors may occur
minrk
approved these changes
Jul 19, 2021
lib/configproxy.js
Outdated
| target: route.data.target, | ||
| }; | ||
| } | ||
| return new Promise((resolve, reject) => { |
There was a problem hiding this comment.
Noting for review:
wrapping this in a promise ensures that targetForReq always returns a Promise, even if routes.getTarget raises directly (as opposed to returning a failing promise).
Comment on lines
+602
to
+605
| .catch(function (e) { | ||
| if (res.finished) throw e; | ||
| that.handleProxyError(500, kind, req, res, e); | ||
| }); |
There was a problem hiding this comment.
These lines are the only changes in this function: adding the catch. prettier chooses a different indentation when there's both a .then and a .catch, which makes this PR look bigger than it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got the following error with https://github.com/globocom/configurable-http-proxy-redis-backend when I hit a URL like
http://chp.example.com/%25. Furthermore, the client didn't get a response forever.Although this error should be taken care of by the store backend, CHP should make a response at least.