Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from DockerHub to quay.io #508

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Move from DockerHub to quay.io #508

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c95f310
Move from DockerHub to quay.io
yuvipanda Oct 18, 2023
054cf47
Actually push to quay.io
yuvipanda Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
# https://github.com/jupyterhub/configurable-http-proxy/settings/secrets/actions
if: startsWith(github.ref, 'refs/tags/')
run: |
docker login -u "${{ secrets.DOCKERHUB_USERNAME }}" -p "${{ secrets.DOCKERHUB_TOKEN }}"
docker login -u "${{ secrets.QUAY_USERNAME }}" -p "${{ secrets.QUAY_PASSWORD }}" quay.io
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the creds, but doesn't change where it's pushed (next step in gettags needs quay.io added, I think)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@minrk how about now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's right, thanks.


# https://github.com/jupyterhub/action-major-minor-tag-calculator
# If this is a tagged build this will return additional parent tags.
Expand All @@ -82,8 +82,8 @@ jobs:
uses: jupyterhub/action-major-minor-tag-calculator@v2
with:
githubToken: ${{ secrets.GITHUB_TOKEN }}
prefix: "jupyterhub/configurable-http-proxy:"
defaultTag: jupyterhub/configurable-http-proxy:noref
prefix: "quay.io/jupyterhub/configurable-http-proxy:"
defaultTag: quay.io/jupyterhub/configurable-http-proxy:noref

- name: Display tags
run: echo "Docker tags ${{ steps.gettags.outputs.tags }}"
Expand Down