Colorize test output and run tests for node 20 and "current" #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
changed the title
consideRatio
force-pushed
the
pr/test-node-20
branch
from
85e8776 to
bfe0f81
Compare
consideRatio
force-pushed
the
pr/test-node-20
branch
from
bfe0f81 to
9d61276
Compare
consideRatio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests are passing for node 20, and the test execution time dropped from 2m24s to 4s --- I'm not sure why, but they pass still and tests seem to run as before. Not sure what that is about.
Update: it was
https.createServerthat has learned to terminate a lot faster in node 20+, all good!