This repository was archived by the owner on Feb 14, 2024. It is now read-only.
Update to check-release@v2
#113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpio
commented
Feb 15, 2023
pyproject.toml
Outdated
|
|
||
| [tool.jupyter-releaser.hooks] | ||
| before-build-npm = [ | ||
| "python -m pip install jupyterlab~=3.1 empack>=2.0.9,<3 jupyter_packaging~=0.10,<2", |
There was a problem hiding this comment.
This is probably because the v1 action used to install the Python package in editable mode before with pip install -e .
|
I think releaser v2 has an issue with not reading the config from But this PR moves the config to |
|
Maybe a follow-up could be to migrate to |
|
I'll proceed with the merge and follow-up with a new release to double check it fixes it. |
|
All good now: https://github.com/jupyterlite/xeus-python-kernel/releases/tag/v0.6.3 I had to update the |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigate releaser workflow failures: https://github.com/jupyterlite/xeus-python-kernel/actions/runs/4185862759