Skip to content
This repository was archived by the owner on Feb 14, 2024. It is now read-only.

Remove duplication of the labextension #15

Merged

Conversation

martinRenou
Copy link
Member

Taking bqplot as a reference implementation for packaging the labextension. Thanks @maartenbreddels who implemented this approach.

This removes the duplication of the labextension in the wheel (which basically divises by two the size of the wheel for xeus-python-kernel, going from ~30MB to ~15MB).

@jtpio if you think this approach makes sense, I'm happy to upstream those changes into jupyterlab/extension-cookiecutter-ts and fix jupyterlab/extension-cookiecutter-ts#220

@martinRenou martinRenou force-pushed the remove_duplication_labextension branch from 96e8a3d to 8bf952b Compare May 20, 2022 15:40
@martinRenou martinRenou marked this pull request as ready for review May 20, 2022 15:44
@martinRenou
Copy link
Member Author

Actually we can get rid of the package.json under site-packages if we follow what bqplot does all the way through (finding the package.json in the prefix).

@martinRenou martinRenou marked this pull request as draft May 20, 2022 16:04
@martinRenou martinRenou marked this pull request as ready for review May 20, 2022 16:09
@martinRenou martinRenou merged commit 930bcb5 into jupyterlite:main May 23, 2022
@martinRenou martinRenou deleted the remove_duplication_labextension branch May 23, 2022 10:58
@maartenbreddels
Copy link

Thanks @maartenbreddels who implemented this approach.

Thanks :) What PR is this referring to btw?

@martinRenou
Copy link
Member Author

It was for the nbextension in bqplot bqplot/bqplot#1228 and we followed together the same pattern for the labextension bqplot/bqplot#1222 :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The labextension is included twice in the Python wheel
2 participants