Skip to content
This repository was archived by the owner on Feb 14, 2024. It is now read-only.

Align repo with the extension template #168

Merged
merged 14 commits into from
Oct 10, 2023
Merged

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 5, 2023

Align the repo with the extension template: https://github.com/jupyterlab/extension-template

This will ease maintenance over time.

It also migrates to using hatch instead of the deprecated jupyter-packaging.

It should also fix the current malformed version in package.json:

"version": "1.0.0-a0",

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

lite-badge 👈 Try it on ReadTheDocs

@jtpio
Copy link
Member Author

jtpio commented Oct 5, 2023

Looking fine on ReadTheDocs:

image

@jtpio
Copy link
Member Author

jtpio commented Oct 5, 2023

Also looking fine testing with the releaser assets locally:

image

@jtpio jtpio marked this pull request as ready for review October 5, 2023 13:19
@jtpio jtpio requested a review from martinRenou October 5, 2023 13:20
@jtpio jtpio mentioned this pull request Oct 5, 2023
5 tasks
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@martinRenou martinRenou merged commit 96aea3e into jupyterlite:main Oct 10, 2023
@jtpio jtpio deleted the hatch branch October 10, 2023 13:51
@jtpio jtpio mentioned this pull request Oct 16, 2023
3 tasks
@martinRenou
Copy link
Member

meeseeksdev backport to 0.x

Copy link

lumberbot-app bot commented Dec 5, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 96aea3e341db3077cdebb749993606b66086f5c7
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #168: Align repo with the extension template'
  1. Push to a named branch:
git push YOURFORK 0.x:auto-backport-of-pr-168-on-0.x
  1. Create a PR against branch 0.x, I would have named this PR:

"Backport PR #168 on branch 0.x (Align repo with the extension template)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

martinRenou pushed a commit to martinRenou/xeus-python-kernel that referenced this pull request Dec 5, 2023
* Align with the extension template

* Lint

* Update tsconfig.json

* Fix prettier config

* Disable noImplicitAny for now

* Fix outputDir

* Fix handling of _version.py

* Update check-release workflow

* Update actions/checkout

* Install empack

* Restore addon and script

* Add empack to build deps

* Remove _version.py

* Update init
martinRenou added a commit that referenced this pull request Dec 5, 2023
* Align with the extension template

* Lint

* Update tsconfig.json

* Fix prettier config

* Disable noImplicitAny for now

* Fix outputDir

* Fix handling of _version.py

* Update check-release workflow

* Update actions/checkout

* Install empack

* Restore addon and script

* Add empack to build deps

* Remove _version.py

* Update init

Co-authored-by: Jeremy Tuloup <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants