Skip to content
This repository was archived by the owner on Feb 14, 2024. It is now read-only.

Fix build #5

Merged
merged 2 commits into from
May 12, 2022
Merged

Fix build #5

merged 2 commits into from
May 12, 2022

Conversation

martinRenou
Copy link
Member

No description provided.

@martinRenou martinRenou mentioned this pull request May 12, 2022
@@ -59,7 +59,7 @@
"@jupyterlite/server": "^0.1.0-alpha.14"
},
"devDependencies": {
"@jupyterlab/builder": "^3.1.0",
"@jupyterlab/builder": "^3.4.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. Although normally the ranges should be compatible, so maybe there is an issue with the check in JupyterLab. iirc the cookiecutter still uses ^3.1.0 and builds fine.

Or the yarn.lock includes multiple @jupyterlab/builder. It would be fine to delete it and recreate it at this stage (or deduplicate).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The weird thing is that yesterday it was building just fine, the error appeared this morning.

If we trigger the CI on the cookiecutter we might be able to replicate the error?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eric released 3.4.1 this morning could it be that the CI just ran during the publication with only a subset of npm packages published hence some errors?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍🏽

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still fails with

ValueError: Extensions require a devDependency on @jupyterlab/builder@^3.4.1, you have a dependency on 3.4.0

@martinRenou martinRenou marked this pull request as ready for review May 12, 2022 08:38
@martinRenou
Copy link
Member Author

Merging as is even if we did not figure out the exact origin of the failure.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants