This repository was archived by the owner on Feb 14, 2024. It is now read-only.
Cache xeus-python build #87
Merged
+120
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to be in conflict. |
|
It does not work yet, I need to actually use the cached build, and make a build only if the cache is outdated |
|
LGTM, you only need to rebase to take my last change you merged. |
check-manifest will not use our cache, it makes an isolated build, so let's not build twice...
martinRenou
force-pushed
the
cache_build
branch
from
5045fb8 to
5aa8786
Compare
|
Thanks for the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the CI run a bit faster: (from ~6 minutes to ~2 minute).
It also makes the dev installation easier, as one only need to run
yarn run buildand this would build the docker image if actually needed