Skip to content
This repository was archived by the owner on Feb 14, 2024. It is now read-only.

Update xeus-python in docs #99

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Conversation

martinRenou
Copy link
Member

No description provided.

@jtpio
Copy link
Member

jtpio commented Dec 22, 2022

Wondering if the docs should build the kernel from source maybe?

This could allow for having RTD previews on PRs?

@martinRenou
Copy link
Member Author

Yeah I've been wanting to do this.

The issue is that Docker is not available on RTD, so we would need to get rid of the Docker setup in order to make it possible, which is feasible.

@martinRenou martinRenou merged commit 36897ab into jupyterlite:main Dec 22, 2022
@martinRenou martinRenou deleted the update branch December 22, 2022 09:44
@jtpio
Copy link
Member

jtpio commented Dec 22, 2022

Ah right.

So probably the xeus refactor (https://xeus.readthedocs.io/en/latest/dev.html) will make it possible to not have to use docker anymore for building xeus python.

@martinRenou
Copy link
Member Author

I don't think that matters much. The Dockerfile does not compile xeus-python at all, it only installs it from emscripten-forge using micromamba.

So the impact of removing the Dockerfile would be that the dev env should have micromamba available. We can also probably allow using conda or mamba instead of micromamba, but that would complicate things a bit for the build workflow.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants