-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(kcl-vet): add ast builder for kcl-vet. #224
Conversation
add ast expr builder for kcl-vet from json/yaml Value. issue #67
Pull Request Test Coverage Report for Build 3209076493
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UT coverage of the major file kclvm/tools/src/vet/expr_builder.rs is pretty low...
More unit tests are required to ensure UT coverage to be at least 95%.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
issue #67
2. What is the scope of this PR (e.g. component or file name):
KCL-Vet
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
add ast expr builder for kcl-vet from json/yaml Value.
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.