Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(kcl-vet): move 'schema_name' from struct to mathod generate. #230

Merged
merged 1 commit into from
Oct 10, 2022
Merged

refactor(kcl-vet): move 'schema_name' from struct to mathod generate. #230

merged 1 commit into from
Oct 10, 2022

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Oct 9, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

issue #67

2. What is the scope of this PR (e.g. component or file name):

kcl-vet

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

move 'schema_name' from struct to mathod generate.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

move 'schema_name' from struct to mathod generate.

issue #67
@zong-zhe zong-zhe added this to the v0.4.4 Release milestone Oct 9, 2022
@zong-zhe zong-zhe requested review from chai2010, Peefy, ldxdl and He1pa October 9, 2022 12:05
@zong-zhe zong-zhe self-assigned this Oct 9, 2022
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3214072248

  • 54 of 54 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1236 unchanged lines in 16 files lost coverage.
  • Overall coverage increased (+3.4%) to 61.51%

Files with Coverage Reduction New Missed Lines %
kclvm/3rdparty/rustc_span/src/source_map.rs 1 27.95%
kclvm/ast/src/token_stream.rs 1 75.0%
kclvm/lexer/src/lib.rs 1 78.65%
kclvm/sema/src/ty/into.rs 1 78.33%
kclvm/sema/src/ty/unify.rs 1 93.91%
kclvm/sema/src/resolver/schema.rs 2 80.99%
kclvm/parser/src/lexer/indent.rs 5 78.31%
kclvm/3rdparty/rustc_span/src/analyze_source_file.rs 10 75.26%
kclvm/sema/src/ty/mod.rs 35 66.02%
kclvm/sema/src/resolver/config.rs 42 79.61%
Totals Coverage Status
Change from base Build 3213156415: 3.4%
Covered Lines: 24403
Relevant Lines: 39673

💛 - Coveralls

Copy link
Contributor

@chai2010 chai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit a0b44e8 into kcl-lang:main Oct 10, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants