Skip to content

ci: turn off GitHub CI for jobs we run in Prow #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

stevekuznetsov
Copy link
Contributor

Signed-off-by: Steve Kuznetsov [email protected]

Part of #324
/assign @ncdc @sttts

@openshift-ci openshift-ci bot assigned ncdc and sttts Jun 3, 2022
@openshift-ci openshift-ci bot requested review from ncdc and sttts June 3, 2022 21:00
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2022
sttts
sttts previously approved these changes Jun 4, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2022
@sttts
Copy link
Member

sttts commented Jun 4, 2022

What is special about the shared server one?

@sttts sttts dismissed their stale review June 4, 2022 08:16

The e2e runtime tripples.

@stevekuznetsov
Copy link
Contributor Author

@sttts shared server requires that I get the actual running of it figured out reproducibly from make and the images wired through etc. Runtime should be 10000% tunable based on how many resources we give the jobs.

@sttts
Copy link
Member

sttts commented Jun 4, 2022

Ack. I think we can move forward here, but would like to see the multiple-run job to be below 20min. Now it's 35min or so, much more than the others.

@ncdc
Copy link
Member

ncdc commented Jun 10, 2022

/lgtm
/approve

c'mon tide 😄

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ncdc,stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ncdc
Copy link
Member

ncdc commented Jun 10, 2022

Manually merging

@ncdc ncdc merged commit 58a887f into kcp-dev:main Jun 10, 2022
@ncdc
Copy link
Member

ncdc commented Jun 10, 2022

/cherry-pick release-0.5

@openshift-cherrypick-robot

@ncdc: new pull request created: #1257

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants