Skip to content

apibinding: make reference.workspace.path optional and defaulted #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

sttts
Copy link
Member

@sttts sttts commented Jun 13, 2022

Set the path automatically to the APIBinding logical cluster through admission defaulting.

This helps with GitOps tools or other apply uses.

@sttts sttts requested a review from qiujian16 June 13, 2022 19:58
@openshift-ci openshift-ci bot requested review from ncdc and stevekuznetsov June 13, 2022 19:58
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2022
@sttts sttts added area/apiexports and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 13, 2022
@sttts sttts mentioned this pull request Jun 13, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [stevekuznetsov,sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2022
@sttts sttts merged commit d31677d into kcp-dev:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiexports lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants