Add KCP CLI arguments to enable home workspaces as well as specific options, especially the groups bound to the get/create ~ permissions #1539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
davidfestal
force-pushed
the
home-workspaces-cli-options
branch
from
4623329 to
8542079
Compare
davidfestal
requested review from
marun,
sttts and
ncdc
and removed request for
ncdc,
sttts and
marun
sttts
reviewed
Jul 15, 2022
| "HOME_CREATOR_GROUPS", homeWorkspaceCreatorGroupReplacement, | ||
| "HOMEPREFIX", homePrefix, |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidfestal, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add KCP CLI arguments to enable home workspaces as well as specific options, especially the groups bound to the get/create ~ permissions
This PR is based on PR #1540 (== first commit)
Related issue(s)
Fixes #1457