e2e/clusterworkspacedeletion: use correct root shard system:master client for deletion checks #1570
Conversation
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
| @@ -208,7 +208,7 @@ func TestWatchCacheEnabledForBuiltinTypes(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| totalCacheHits, secretsCacheHit := collectCacheHitsFor(ctx, t, server.RootShardConfig(t), "/core/secrets") | |||
| totalCacheHits, secretsCacheHit := collectCacheHitsFor(ctx, t, server.RootShardSystemMasterBaseConfig(t), "/core/secrets") | |||
There was a problem hiding this comment.
mhm, wondering why the kcp-admin doesn't work here
There was a problem hiding this comment.
shouldn't kcp-admin have access to the /metrics endpoint?
There was a problem hiding this comment.
kcp-admin against the root shard will work. Note: my change here is just a rename, not a change in behaviour of RootShardConfig/RootShardSystemMasterBaseConfig. I.e. am just pointing out that this is a system:master user (was also before the rename).
…ient for deletion checks
sttts
force-pushed
the
sttts-e2e-clusterworkspacedeletion-root-clients
branch
from
7956913 to
12078ca
Compare
|
New changes are detected. LGTM label has been removed. |
|
Pure rebase. |
|
/lgtm |
The deletion checks have to skip authorization because authz would lead to 403 on deleted workspaces, i.e. you cannot look into the logical cluster then. Hence, we need a
system:masterclient. We have that wired for the root shard.