Skip to content

docs: tweaks to the Location concept description #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

markmc
Copy link
Contributor

@markmc markmc commented Jul 21, 2022

The "operation concerns" bit was clarified elsewhere by Stefan.

Suggesting dropping the "kube conformance" bit because it probably needs further clarification so that it doesn't conflict with
https://github.com/kcp-dev/kcp/blob/main/FAQ.md#will-kcp-be-able-to-pass-the-k8s-conformance-tests-in-cncf-conformance-suites

The "operation concerns" bit was clarified elsewhere by Stefan.

Suggesting dropping the "kube conformance" bit because it probably needs
further clarification so that it doesn't conflict with:

https://github.com/kcp-dev/kcp/blob/main/FAQ.md#will-kcp-be-able-to-pass-the-k8s-conformance-tests-in-cncf-conformance-suites
@openshift-ci openshift-ci bot requested review from davidfestal and ncdc July 21, 2022 10:28
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2022

Hi @markmc. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Member

sttts commented Jul 21, 2022

Thanks for the clarification of the docs.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2022
@openshift-merge-robot openshift-merge-robot merged commit 4c8d6f8 into kcp-dev:main Jul 21, 2022
@markmc markmc deleted the location-docs branch September 14, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants