Skip to content

[0.6] Fix flaky informers #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented Aug 1, 2022

Like-port of #1649, pulling in kcp-dev/kubernetes#86 which backports 85 onto feature-logical-clusters-1.23

@sttts
Copy link
Member

sttts commented Aug 1, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Aug 1, 2022
@ncdc
Copy link
Member Author

ncdc commented Aug 2, 2022

Backported the other commit from #1613 (one already was). Made a slight change (wait.ForeverTestTimeout/30 --> wait.ForeverTestTimeout)

sttts and others added 2 commits August 2, 2022 10:37
Update Kubernetes to pull in the commit that retains rest storage for
wildcard partial metadata CRD requests as long as there is at least 1
CRD for that group-resource still in the system.

Signed-off-by: Andy Goldstein <[email protected]>
@ncdc ncdc force-pushed the 0.6/fix-crd-remove-dead-storage-wildcard-partial-metadata branch from 040b516 to 40e6d35 Compare August 2, 2022 14:46
@ncdc
Copy link
Member Author

ncdc commented Aug 2, 2022

Was all green. Please review backport-ish commit

@sttts
Copy link
Member

sttts commented Aug 2, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2022
@openshift-merge-robot openshift-merge-robot merged commit 5a02cd4 into kcp-dev:release-0.6 Aug 2, 2022
@ncdc ncdc deleted the 0.6/fix-crd-remove-dead-storage-wildcard-partial-metadata branch August 2, 2022 16:34
@sttts
Copy link
Member

sttts commented Aug 2, 2022

Worth v0.6.4.

@ncdc
Copy link
Member Author

ncdc commented Aug 2, 2022

Agreed, will do

@ncdc
Copy link
Member Author

ncdc commented Aug 2, 2022

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants