Fix leftover resource when deleting a namespace #1743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-merge-robot
added
the
needs-rebase
jmprusi
force-pushed
the
jmprusi/fix-leftover-resources-namespace
branch
from
16bebba to
53dc7c9
Compare
openshift-merge-robot
removed
the
needs-rebase
jmprusi
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
jmprusi
force-pushed
the
jmprusi/fix-leftover-resources-namespace
branch
3 times, most recently
from
bcad0a5 to
f7d1cc0
Compare
jmprusi
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
jmprusi
force-pushed
the
jmprusi/fix-leftover-resources-namespace
branch
from
f7d1cc0 to
b0c22f0
Compare
|
/lgtm |
davidfestal
approved these changes
Aug 22, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidfestal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1720
Follow-up: #398